[PATCH 1/2] Make sure all threads are done before install

Chris Lumens clumens at redhat.com
Fri May 3 14:09:47 UTC 2013


> @@ -110,6 +113,12 @@ def doInstall(storage, payload, ksdata, instClass):
>      steps += 5  # pre setup phase, packages setup, packages, bootloader, post install
>      progressQ.send_init(steps)
>  
> +    # This should be the only thread running, wait for the others to finish if not.
> +    if threadMgr.running > 1:
> +        with progress_report(_("Waiting for %s threads to finish") % (threadMgr.running-1)):
> +            map(log.debug, ("Thread %s is running" % n for n in threadMgr.names))
> +            threadMgr.wait_all()
> +
>      with progress_report(_("Setting up the installation environment")):
>          ksdata.addons.setup(storage, ksdata, instClass)
>  

How often do you expect this error to be shown?  I don't think showing
jargon like "threads" to the user is a great idea, so a rephrasing might
be in order.  I'll be a little less concerned if the odd kickstart user
is the only one to see it.

- Chris


More information about the anaconda-patches mailing list