[PATCH 1/3] LayoutIndicator widget

Vratislav Podzimek vpodzime at redhat.com
Fri May 3 08:42:58 UTC 2013


On Thu, 2013-05-02 at 10:56 -0400, Chris Lumens wrote:
> > > Is this widget usable with just the keyboard?
> > It's not, but I'm not sure we want something like that. The primary
> > purpose of the widget is to indicate which layout is currently
> > activated. Keyboard switching should be done by the shortcut (like
> > Alt+Shift) and the widget intentionally doesn't grab focus (which would
> > be needed to make it usable just with the keyboard), so that it can be
> > clicked with the focus kept in the text field that is being edited.
> 
> Okay, thanks for the explanation.  That makes sense to me.
> 
> > > I really only have two major complaints with this new widget, and this
> > > is one.  I think the white background makes it look weird and
> > > unfinished.  I would much rather find some other way to make it look
> > > activatable while still fitting in better with how everything else
> > > looks.
> > Well, this was actually Máirín's idea and I must say I like it. The
> > other way to make the widget compact and looking activatable could be a
> > frame around it [1], but that looks to me really old school with the
> > grey background. Any other ideas?
> > 
> > [1] http://vpodzime.fedorapeople.org/layout_indicator_old_school.png
> 
> Hah, I wonder what it says about me that I think the one with the frame
> looks nicer.  I don't really have any good ideas right now, but I didn't
> have any to begin with.  I'm willing to go with the white background
> version for now (as long as it's got the left alignment from the other
> link you sent) and we can always work on making it look different later.
I was quite sure somebody would come with such response. :)

Okay, I'm definitely for going with the background and doing any
additional tweaks later. I'm pushing the corrected patches (with the
modified alignment) so that they appear in the Beta TCs and can be
tested.

Thanks,

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list