[PATCH 2/3] Add layout indicator to the BaseWindow

Vratislav Podzimek vpodzime at redhat.com
Thu May 2 10:58:20 UTC 2013


On Tue, 2013-04-30 at 11:42 -0400, Chris Lumens wrote:
> > Also make Done button use two cells in the grid because BaseWindow's navigation
> > area has now three rows instead of two (layout indicator added) and the "Done"
> > button should be centered between the second and the third rows.
> 
> That's fine, but can you move the Done button to appear at either the
> top of one cell or the bottom of another?  Its new layout has kind of a
> strange amount of whitespace around it.
You mean something like that --
http://vpodzime.fedorapeople.org/new_spoke_header_layout.png ? Also
please note the change of the indicator's position.

> > @@ -267,7 +270,7 @@ static void anaconda_base_window_init(AnacondaBaseWindow *win) {
> >  
> >      /* Create the beta label. */
> >      win->priv->beta_label = gtk_label_new(NULL);
> > -    markup = g_markup_printf_escaped("<span foreground='red' weight='bold' size='large'>%s</span>", _(DEFAULT_BETA));
> > +    markup = g_markup_printf_escaped("<span foreground='red' weight='bold' size='medium'>%s</span>", _(DEFAULT_BETA));
> >      gtk_label_set_markup(GTK_LABEL(win->priv->beta_label), markup);
> >      g_free(markup);
> >      gtk_misc_set_alignment(GTK_MISC(win->priv->beta_label), 0, 0);
> 
> Remember to make this change in anaconda_base_window_retranslate as
> well.  If you would prefer, you could move to using a format_ function
> like I am doing in MountpointSelector.c and SpokeSelector.c  Just grep
> for that.
Done, thanks for pointing that out, I had no idea why the label had
large font on the welcome screen.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list