[PATCH] Move the Desired Capacity label and spinner into its own row (#907883, #904999).

Vratislav Podzimek vpodzime at redhat.com
Wed Mar 27 11:14:51 UTC 2013


On Tue, 2013-03-26 at 11:52 -0400, Chris Lumens wrote:
> All that text plus the spinner, plus the other widgets on the screen, makes the
> whole screen too wide to run at 800x600.  This seems like a reasonable fix to
> the problem.
> ---
>  pyanaconda/ui/gui/spokes/custom.glade | 82 +++++++++++++++--------------------
>  1 file changed, 35 insertions(+), 47 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade
> index 3f8516a..d0d25db 100644
> --- a/pyanaconda/ui/gui/spokes/custom.glade
> +++ b/pyanaconda/ui/gui/spokes/custom.glade
> @@ -613,24 +613,6 @@ use.  Try something else?</property>
>                                    </packing>
>                                  </child>
>                                  <child>
> -                                  <object class="GtkLabel" id="label5">
> -                                    <property name="visible">True</property>
> -                                    <property name="can_focus">False</property>
> -                                    <property name="halign">end</property>
> -                                    <property name="xalign">0</property>
> -                                    <property name="label" translatable="yes">&lt;b&gt;_Desired Capacity (MB):&lt;/b&gt;</property>
> -                                    <property name="use_markup">True</property>
> -                                    <property name="use_underline">True</property>
> -                                    <property name="mnemonic_widget">sizeSpinner</property>
> -                                  </object>
> -                                  <packing>
> -                                    <property name="left_attach">2</property>
> -                                    <property name="top_attach">2</property>
> -                                    <property name="width">1</property>
> -                                    <property name="height">1</property>
> -                                  </packing>
> -                                </child>
> -                                <child>
>                                    <object class="GtkEntry" id="labelEntry">
>                                      <property name="visible">True</property>
>                                      <property name="can_focus">True</property>
> @@ -645,24 +627,6 @@ use.  Try something else?</property>
>                                    </packing>
>                                  </child>
>                                  <child>
> -                                  <object class="GtkSpinButton" id="sizeSpinner">
> -                                    <property name="visible">True</property>
> -                                    <property name="can_focus">True</property>
> -                                    <property name="halign">end</property>
> -                                    <property name="invisible_char">●</property>
> -                                    <property name="width_chars">7</property>
> -                                    <property name="invisible_char_set">True</property>
> -                                    <property name="adjustment">sizeAdjustment</property>
> -                                    <property name="numeric">True</property>
> -                                  </object>
> -                                  <packing>
> -                                    <property name="left_attach">3</property>
> -                                    <property name="top_attach">2</property>
> -                                    <property name="width">1</property>
> -                                    <property name="height">1</property>
> -                                  </packing>
> -                                </child>
> -                                <child>
>                                    <object class="GtkLabel" id="label13">
>                                      <property name="visible">True</property>
>                                      <property name="can_focus">False</property>
> @@ -695,16 +659,40 @@ use.  Try something else?</property>
>                                    </packing>
>                                  </child>
>                                  <child>
> -                                  <placeholder/>
> -                                </child>
> -                                <child>
> -                                  <placeholder/>
> -                                </child>
> -                                <child>
> -                                  <placeholder/>
> +                                  <object class="GtkLabel" id="label5">
> +                                    <property name="visible">True</property>
> +                                    <property name="can_focus">False</property>
> +                                    <property name="halign">end</property>
> +                                    <property name="xalign">0</property>
> +                                    <property name="label" translatable="yes">&lt;b&gt;_Desired Capacity (MB):&lt;/b&gt;</property>
> +                                    <property name="use_markup">True</property>
> +                                    <property name="use_underline">True</property>
> +                                    <property name="mnemonic_widget">sizeSpinner</property>
> +                                  </object>
> +                                  <packing>
> +                                    <property name="left_attach">0</property>
> +                                    <property name="top_attach">3</property>
> +                                    <property name="width">1</property>
> +                                    <property name="height">1</property>
> +                                  </packing>
>                                  </child>
>                                  <child>
> -                                  <placeholder/>
> +                                  <object class="GtkSpinButton" id="sizeSpinner">
> +                                    <property name="visible">True</property>
> +                                    <property name="can_focus">True</property>
> +                                    <property name="halign">end</property>
> +                                    <property name="invisible_char">●</property>
> +                                    <property name="width_chars">7</property>
> +                                    <property name="invisible_char_set">True</property>
> +                                    <property name="adjustment">sizeAdjustment</property>
> +                                    <property name="numeric">True</property>
> +                                  </object>
> +                                  <packing>
> +                                    <property name="left_attach">1</property>
> +                                    <property name="top_attach">3</property>
> +                                    <property name="width">1</property>
> +                                    <property name="height">1</property>
> +                                  </packing>
>                                  </child>
>                                </object>
>                                <packing>
> @@ -899,9 +887,6 @@ use.  Try something else?</property>
>                                        </packing>
>                                      </child>
>                                      <child>
> -                                      <placeholder/>
> -                                    </child>
> -                                    <child>
>                                        <object class="GtkComboBox" id="raidLevelCombo">
>                                          <property name="visible">True</property>
>                                          <property name="can_focus">False</property>
> @@ -920,6 +905,9 @@ use.  Try something else?</property>
>                                          <property name="height">1</property>
>                                        </packing>
>                                      </child>
> +                                    <child>
> +                                      <placeholder/>
> +                                    </child>
>                                    </object>
>                                  </child>
>                                  <child type="label">
Looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list