[PATCH] Allow setting the default GID of the new user.

Chris Lumens clumens at redhat.com
Wed Mar 20 20:34:41 UTC 2013


> diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
> index d0b67cd..d62a2c7 100644
> --- a/pyanaconda/ui/gui/spokes/user.py
> +++ b/pyanaconda/ui/gui/spokes/user.py
> @@ -103,11 +103,9 @@ class AdvancedUserDialog(GUIObject):
>                  self._user.uid = None
>  
>              if self.builder.get_object("c_gid").get_active():
> -                pass
> -                #self._user.gid = int(self.builder.get_widget("gid").get_value())
> +                self._user.gid = int(self.builder.get_widget("gid").get_value())
>              else:
> -                #self._user.gid = None
> -                pass
> +                self._user.gid = None
>  
>              groups = self.builder.get_object("t_groups").get_text().split(",")
>              self._user.groups = []

Do we need to do any validation of the value provided?  I'm thinking
whitespace only strings, letters, etc.

Also, I like to increase the version of pykickstart in the spec file to
match, when updating things like this in anaconda.

- Chris


More information about the anaconda-patches mailing list