[PATCH lorax/master] sysutils: add -x to cp in linktree

Vratislav Podzimek vpodzime at redhat.com
Tue Mar 19 10:21:17 UTC 2013


On Mon, 2013-03-18 at 11:59 -0400, Will Woods wrote:
> Since you can't make cross-device links, you'd think that cp -l (make
> links) would imply -x (don't cross devices).
> 
> You'd be wrong.
> ---
>  src/pylorax/sysutils.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/pylorax/sysutils.py b/src/pylorax/sysutils.py
> index 6ce4c93..8743b9a 100644
> --- a/src/pylorax/sysutils.py
> +++ b/src/pylorax/sysutils.py
> @@ -106,5 +106,4 @@ def remove(target):
>          os.unlink(target)
>  
>  def linktree(src, dst):
> -    runcmd(["/bin/cp", "-al", src, dst])
> -
> +    runcmd(["/bin/cp", "-alx", src, dst])
Looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list