[pykickstart/rhel6] Raise error on multiple clearpart commands (#852523)

Chris Lumens clumens at redhat.com
Thu Jun 27 21:13:02 UTC 2013


> diff --git a/pykickstart/commands/clearpart.py b/pykickstart/commands/clearpart.py
> index 5d6276a..c2c14c7 100644
> --- a/pykickstart/commands/clearpart.py
> +++ b/pykickstart/commands/clearpart.py
> @@ -81,6 +81,9 @@ class FC3_ClearPart(KickstartCommand):
>          return op
>  
>      def parse(self, args):
> +        if self.type is not None:
> +            raise KickstartValueError, formatErrorMsg(self.lineno, msg=_("clearpart already set"))
> +
>          (opts, extra) = self.op.parse_args(args=args, lineno=self.lineno)
>          self._setToSelf(self.op, opts)
>          return self

In general, I don't like to make multiple instances of a kickstart
command into errors.  This is so that kickstart files can make use of a
%include to do some primitive form of inheritance - a site can use some
generic base kickstart file, and then override directives later in more
specific %includes.

- Chris


More information about the anaconda-patches mailing list