[PATCHv2] Beware of parted possibly returning unicode objects (#973019)
Vratislav Podzimek
vpodzime at redhat.com
Tue Jun 25 09:29:02 UTC 2013
On Mon, 2013-06-24 at 10:56 -0700, Brian C. Lane wrote:
> On Mon, Jun 24, 2013 at 04:08:25PM +0200, Vratislav Podzimek wrote:
> > I've tested this patch on live and netinst installations and nothing
> > seemed to be broken by it.
>
> After actually paying attention I realized these are pyparted objects
> and was able to reproduce with TC6 live -- pyparted is returning unicode
> objects and it really shouldn't. This is caused by a py3.x set of
> patches, so I'm NAK for these patches. We need to fix this in pyparted,
> there's no reason for it to be returning unicode objects. At the most it
> should utf-8 encode anything and return a string object.
Thanks for looking at this, I didn't realize we can fix this on the
right side. Returning utf-8-encoded strings should be okay. I believe
there could be non-ascii characters in labels, for example.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list