f19/master include custom storage in anaconda-ks.cfg (#929119)

David Lehman dlehman at redhat.com
Thu Jun 13 01:13:43 UTC 2013


On Wed, 2013-06-12 at 17:27 -0700, Brian C. Lane wrote:
> On Wed, Jun 12, 2013 at 12:22:52PM -0500, David Lehman wrote:
> > It doesn't yet include the iscsi, fcoe, zfcp commands.
> > 
> > Initially I wanted to add the custom config to ksdata in the custom spoke's
> > apply method, but that turns out to be fairly complicated with multiple
> > visits to the storage spoke.
> 
> This is a pretty big change for F19, and it seems to flip things
> upside-down -- now blivet is driving the kickstart data instead of the
> other way around. I'd like to see what everyone else things before we
> push this for f19.

Yeah, this is a sort of scary area. Blivet and ksdata should already be
synced up on ignoredisk, clearpart (drives only; see below) and autopart
because blivet isn't rigged to really require ksdata. The part of
updateKSData that updates those pieces is only there for completeness.

By just dumping the storage config into ksdata once at the last possible
moment we avoid the complexities of actually having custom storage in
anaconda be driven by ksdata.

The real change is that we will now represent clearpart correctly (since
it's no longer all|linux|none in ui.gui) and will also include any other
settings from the custom spoke, including resizes.

Dave



More information about the anaconda-patches mailing list