[PATCH 1/3] Add a "Delete All" button to the reclaim dialog.

Vratislav Podzimek vpodzime at redhat.com
Mon Jun 10 09:00:32 UTC 2013


On Fri, 2013-06-07 at 13:48 -0400, Chris Lumens wrote:
> > I think the "diskView-selection" widget should be pulled once and stored
> > as e.g. "self._viewSelection". If nothing else, in case of changing the
> > widget's ID in the .glade file, it won't require a change in multiple
> > places.
> 
> Yeah, good idea.  The number of times I was grabbing that got away from
> me.  Fixed locally.
> 
> > Is there any particular reason for using 'get' instead of
> > [itr][DEVICE_ID_COL]? 
> 
> .get was already in use elsewhere in the file, and it seemed like a good
> idea at the time.  Patch #3 gets rid of this, though.  I can clean it up
> in git history if you really care.
Ah,I've overlooked that. No problem than. Thanks.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list