[PATCH 2/3] Do change root properly when creating users

Vratislav Podzimek vpodzime at redhat.com
Thu Jun 6 07:56:02 UTC 2013


On Wed, 2013-06-05 at 13:38 -0700, Brian C. Lane wrote:
> On Wed, Jun 05, 2013 at 02:17:20PM +0200, Vratislav Podzimek wrote:
> > See e7b877c296e8d43dc32b75888b7fbf9790565c01 for more info.
> > 
> > Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> > ---
> >  pyanaconda/users.py | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/pyanaconda/users.py b/pyanaconda/users.py
> > index 212184b..7ec594c 100644
> > --- a/pyanaconda/users.py
> > +++ b/pyanaconda/users.py
> > @@ -246,6 +246,7 @@ class Users:
> >          if not childpid:
> >              if not root in ["","/"]:
> >                  os.chroot(root)
> > +                os.chdir("/")
> >                  del(os.environ["LIBUSER_CONF"])
> >  
> >              self.admin = libuser.admin()
> > -- 
> > 1.7.11.7
> 
> See 2 other places in users.py where we have os.chroot, why not add this
> to them as well?
Good point, thanks! I didn't notice the other two places. Fixing
locally.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list