[master/f19-branch] Initial Setup related patches

Brian C. Lane bcl at redhat.com
Tue Jun 4 15:49:43 UTC 2013


On Tue, Jun 04, 2013 at 01:07:24PM +0200, Vratislav Podzimek wrote:
> On Mon, 2013-06-03 at 13:31 -0700, Brian C. Lane wrote:
> > On Tue, May 28, 2013 at 03:15:55PM +0200, Vratislav Podzimek wrote:
> > > These patches are needed for the Initial Setup, together with one patch for its
> > > own code.
> > > 
> > > Vratislav Podzimek (3):
> > >   Be more specific about what was set in the kickstart (#963970)
> > 
> > This one is ok.
> > 
> > >   Add flag indicating if running in the Initial Setup
> > >   Refer to installation not kickstart in the Initial Setup (#963968)
> > 
> > I really don't like having to stuff in switches and conditional checks
> > for initial setup. Anyone have any better ideas?
> I don't like it either, but we have switches and conditional checks also
> for many other cases and for the i-s, there won't be much of them. And
> if we stop referring to "kickstart" in status messages (I think "Root
> password is set" is equally good as "Root password was set by
> kickstart"), none such switch should be needed. Still at least the
> addons and some future code may need a flag indicating if the code is
> run as part of the i-s or not.

I agree, more generic messages where appropriate are better than
switches.


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130604/9bfb33c3/attachment.sig>


More information about the anaconda-patches mailing list