[f19-branch/master 0/2] Clean up password strength

Vratislav Podzimek vpodzime at redhat.com
Tue Jun 4 11:19:18 UTC 2013


On Mon, 2013-06-03 at 11:08 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> We were inconsistent in our use of strength meters. This fixes a problem with
> user entry not showing the strength before entering the confirmation password,
> and it adds a strength meter to the root password entry. It uses the info bar
> to show that they mismatch while still showing the strength of the password
> entered. This is consistent with the LUKS passphrase entry dialog.
> 
> I think it would be nice to have these on F19.
> 
> Brian C. Lane (2):
>   Show User password strength during entry
>   Add password strength to root password spoke
> 
>  pyanaconda/ui/gui/spokes/password.glade | 55 ++++++++++++++++++++++++++++--
>  pyanaconda/ui/gui/spokes/password.py    | 59 ++++++++++++++++++++++++++++++++-
>  pyanaconda/ui/gui/spokes/user.py        | 36 +++++++++-----------
>  3 files changed, 126 insertions(+), 24 deletions(-)
I've uploaded a screenshot of the new look [1] and I think:
1) the label next to the level bar should be vertically centered to the
same level as the bar

2) there should be some spacing between the upmost label and the
checkboxes

3) an "empty password" shouldn't fill the half of the meter with the
first character typed getting it to lowest level

[1] http://vpodzime.fedorapeople.org/root_pw_meter.png

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list