[master/f19-branch] Fix user creation with existing home directory

Vratislav Podzimek vpodzime at redhat.com
Tue Jun 4 10:56:53 UTC 2013


On Mon, 2013-06-03 at 13:49 -0700, Brian C. Lane wrote:
> On Thu, May 30, 2013 at 04:53:41PM +0200, Vratislav Podzimek wrote:
> > When using an existing /home partition, we shouldn't fail to create a user that
> > already has the home directory under it. We should create the user and just
> > change the owner of the particular home directory to the UID of the newly
> > created user.
> 
> I don't think this is a good idea. I don't think we can clearly
> anticipate all the possible problems with changing ownership of all the
> files. It might be ok to just change the ones owned by the same uid/gid
> as the top level directory, but even then I'm reluctant to change user
> data.
I'm for changing the ownership of the files/directories owned by the
same uid/gid as the top level directory. Doing nothing would result in a
completely broken system if the newly created user has a different uid
than the uid of "their" home directory (which is not so unlikely to
happen).

> 
> The original problem can be fixed fairly easily by the user after
> install.
I don't think it would be intuitive to find out what the problem is and
how to fix it. On the other hand, preserving /home is a common use case.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list