[master/rhel7-branch] A bit controversial one for the MountpointSelectors' usage

Vratislav Podzimek vpodzime at redhat.com
Mon Jul 29 12:39:32 UTC 2013


The following patch fixes the bug #975838 by moving the focus changes handling
from the MountpointSelector widget to the Page and spoke it appears in,
respectively. The controversy lies in making the MountpointSelector's behaviour
relying on the widget it is placed into. The MounpointSelector widget per se no
longer handles focus changes correctly and it looks like being selected/chosen
even if it loses focus. However, this is what we want -- to keep it look like
that when user clicks to the right part of the screen to change parameters of
the mount point being chosen. And since I doubt anybody will reuse the
MountpointSelector as a standalone widget without the Page and the Accordion I
think this change could be done.

I've recorded a video preview [1] showing the functionality with this patch
applied.

[1] http://vpodzime.fedorapeople.org/MountpointSelector_focus.webm

Let me know if I should add more comments to some places.

Vratislav Podzimek (1):
  Handle focus changes of MountpointSelectors from outside (#975838)

 pyanaconda/ui/gui/spokes/custom.py        |  2 ++
 pyanaconda/ui/gui/spokes/lib/accordion.py |  6 ++++++
 widgets/src/MountpointSelector.c          | 31 ++++++++-----------------------
 3 files changed, 16 insertions(+), 23 deletions(-)

-- 
1.7.11.7



More information about the anaconda-patches mailing list