[PATCH] Verify user ready to proceed with installation in TUI. (#975793)

Samantha N. Bueno sbueno+anaconda at redhat.com
Wed Jul 24 14:23:51 UTC 2013


On Tue, Jul 23, 2013 at 09:58:37AM -0700, Brian C. Lane wrote:
> On Tue, Jul 23, 2013 at 08:53:12AM -0400, Samantha N. Bueno wrote:
> > On Mon, Jul 22, 2013 at 05:17:59PM -0700, Brian C. Lane wrote:
> > > On Mon, Jul 22, 2013 at 08:32:11AM -0400, Samantha N. Bueno wrote:
> > > > Another for rhel7-branch as well.
> > > > 
> > > > I feel like a better-worded message could be shown to users, so please
> > > > feel free to offer suggestions.
> > > 
> > > Wouldn't it be clearer to change the prompt? Instead of 'c' to continue
> > > have it say "'s' to start install"
> > 
> > Yeah, you have a point. I thought the prompt was at risk of looking a
> > little too crowded, but here's a screenshot with the option added in:
> > http://sbueno.fedorapeople.org/images/975793.jpg
> > 
> > What do you think?
> 
> I was thinking it would replace 'c' continue. If both of them are there
> what does 'c' do?

'c' is only really useful in some of the spokes (storage.py and user.py
for instance) -- it is used as an indicator that the user is ready to
move on to the next step of configuration (disk selection -> partition
options -> partition scheme selection), and upon completing dumps the
user back out to the summary hub.

I think it's still necessary--particularly in a spoke like storage where
you can select multiple disks, for instance. How else is the installer
to know when you are ready to proceed?

As an alternative solution, I can just make a custom prompt in the
spokes where 'c' really matters--it's a trivial change, fortunately.
http://sbueno.fedorapeople.org/images/975793-revised.jpg
 
> > Even with a clear "start installation" option though, I feel having the
> > yes/no question present is still a good idea, just because it's easy
> > enough to accidentally hit the wrong key.
> 
> I agree with Chris that we shouldn't add the confirmation. If starting
> the install requires s instead of c at this point it makes it harder to
> do it on accident.

Sounds fine to me; I've already removed the confirmation locally.

Samantha


More information about the anaconda-patches mailing list