[PATCH] Add support for NFS as install source in TUI. (#971298)

Brian C. Lane bcl at redhat.com
Tue Jul 23 17:00:45 UTC 2013


On Tue, Jul 23, 2013 at 10:55:40AM -0400, Samantha N. Bueno wrote:
> On Tue, Jul 23, 2013 at 08:42:45AM +0200, Vratislav Podzimek wrote:
> > On Mon, 2013-07-22 at 11:28 -0400, Samantha N. Bueno wrote:
> > > Note: should go into rhel7-branch also.
> > > 
> > > Resolves: rhbz#971298
> > > ---
> > >  pyanaconda/ui/tui/spokes/source.py | 68 ++++++++++++++++++++++++++++++++++----
> > >  1 file changed, 62 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/pyanaconda/ui/tui/spokes/source.py b/pyanaconda/ui/tui/spokes/source.py
> > > index cd5f718..3714364 100644
> > > --- a/pyanaconda/ui/tui/spokes/source.py
> > > +++ b/pyanaconda/ui/tui/spokes/source.py
> > > @@ -32,6 +32,7 @@ from pyanaconda.constants import THREAD_SOURCE_WATCHER, THREAD_SOFTWARE_WATCHER,
> > >  from pyanaconda.constants import THREAD_PAYLOAD_MD, THREAD_STORAGE, THREAD_CHECK_SOFTWARE
> > >  
> > >  import re
> > > +from .... import time
> > As Brian already suggested, 'import time' would be better.
> 
> The timezone spoke is named time.py; without the path specification,
> python will try and import from there.
> Hm, now that I think about it, I suspect the GUI spoke was named
> "datetime_spoke.py" to avoid the exact same problem since there is
> already a "datetime" module provided by python-libs. ;)
> In that event, how do you feel on renaming time.py ->time_spoke.py? It
> would effectively require zero change to anything else in the code.

Ah, ha! Yes, that's the right thing to do.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130723/b32913a8/attachment.sig>


More information about the anaconda-patches mailing list