[PATCH 1/2 master] Do not populate devicetree after each single login in iscsi dialog (#740105)
Radek Vykydal
rvykydal at redhat.com
Fri Jul 19 13:08:01 UTC 2013
Instead, populate it when leaving the dialog.
Populating the tree after each single login is not necessary and it is causing
this issue in iface-bound iSCSI multipath scenario (eg sdf being a node bound
via p3p1 and sdg being the node bound via p3p2):
The first populate after logging via p3p1 sets a format (eg DiskLabel) for sdf.
In the second populate after logging via p3p2 creating sdg, the sdg format is
correctly identified as multipath_member, but for sdf original format is found
and kept. As a consequence, sdf is not filtered out by
pyanaconda/ui/lib/disks.py:GetDisks() function and is displayed in filter UI
(as well as in advanced storage disk overview).
With the patch, the filter UI correctly displays only mpath device (as in
RHEL6) - if both multipath members / iscsi sessions are added in single add
iscsi dialog run instance, which is still improvement.
---
pyanaconda/ui/gui/spokes/advstorage/iscsi.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
index 92f9e6c..786631c 100644
--- a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
+++ b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py
@@ -162,6 +162,9 @@ class ISCSIDialog(GUIObject):
def run(self):
rc = self.window.run()
self.window.destroy()
+ # We need to call this to get the device nodes to show up
+ # in our devicetree.
+ self.storage.devicetree.populate()
return rc
##
@@ -352,9 +355,6 @@ class ISCSIDialog(GUIObject):
row[1] = False
- # We need to call this to get the device node to show up
- # in our devicetree.
- self.storage.devicetree.populate()
# Only logging into one at a time.
break
--
1.7.11.7
More information about the anaconda-patches
mailing list