[PATCH 3/4] Fix disklabel handling for multiple calls to processActions.

Vratislav Podzimek vpodzime at redhat.com
Thu Jul 18 15:53:05 UTC 2013


On Thu, 2013-07-18 at 09:13 -0500, David Lehman wrote:
> ---
>  blivet/devicetree.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/blivet/devicetree.py b/blivet/devicetree.py
> index 0a8503f..e67340a 100644
> --- a/blivet/devicetree.py
> +++ b/blivet/devicetree.py
> @@ -250,6 +250,11 @@ class DeviceTree(object):
>  
>                  self._completed_actions.append(self._actions.pop(0))
>  
> +        # removal of partitions makes use of originalFormat, so it has to stay
> +        # up to date in case of multiple passes through this method
> +        for disk in [d for d in self.devices if d.partitioned]:
This could be '(d for d in self.devices if d.partitioned)' to avoid
creating and allocating a temporary list. Otherwise these all look good
to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list