[rhel6-branch][PATCH] Use correct error message when running out of partition slots (#859420)

Vratislav Podzimek vpodzime at redhat.com
Thu Jul 18 14:07:53 UTC 2013


On Wed, 2013-07-17 at 13:26 +0200, Martin Kolman wrote:
> When running out of partition slots, make sure the error dialog
> correctly reports "no free slots" and not "no free space".
> 
> Signed-off-by: Martin Kolman <mkolman at redhat.com>
> ---
>  storage/partitioning.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index 2daa4bb..a42906a 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -1194,6 +1194,10 @@ def allocatePartitions(storage, disks, partitions, freespace):
>                  log.debug("found free space for bootable request")
>                  break
>  
> +        if getNextPartitionType(disklabel.partedDisk) is None:
> +            raise PartitioningError("no free partition slots on %s" % 
> +                                    _disk.name)
> +
>          if free is None:
>              raise PartitioningError("not enough free space on disks")
>  
Looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list