[master][PATCH] Cleanup arch.py redux

Vratislav Podzimek vpodzime at redhat.com
Thu Jul 18 13:57:44 UTC 2013


On Tue, 2013-07-16 at 14:55 -0500, Mark Hamzy wrote:
> Clean up arch.py to have a common style, consistent indentation, removed the obvious
> C to Python rewrite, and removed the globals and function short circuiting.
> 
> ---
>  blivet/arch.py | 218 ++++++++++++++++++++++++---------------------------------
>  1 file changed, 92 insertions(+), 126 deletions(-)
$ pylint -E blivet/arch.py 
No config file found, using default configuration
************* Module blivet.arch
E: 83,4:getPPCMachine: Undefined variable 'log'
E:101,4:getPPCMacID: Undefined variable 'log'
E:124,8:getPPCMacGen: Undefined variable 'log'
E:131,4:getPPCMacGen: Undefined variable 'log

Otherwise this looks good to me, thanks for the additional changes.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list