[PATCH] Make the Welcome spoke wait for Geolocation lookup to finish (#975193)

Martin Kolman mkolman at redhat.com
Wed Jul 10 11:59:20 UTC 2013


On Tue, 2013-07-09 at 11:40 -0700, Brian C. Lane wrote:
> On Mon, Jul 08, 2013 at 07:33:22PM +0200, Martin Kolman wrote:
> 
> > @@ -151,16 +153,17 @@ def get_territory_code():
> >      - the geolocation module was not activated (init & refresh were not called)
> >       - this is for example the case during image and directory installs
> >  
> > +    :param wait: wait for wait seconds for lookup in progress to finish
> 
> This should either copy the whole description of how wait works, or
> point to _get_location_info_instance for the full docs.
Good point, I'll go for including the full docs & fix it locally.

>  I don't really
> like the idea of a T/F/Number variable, but I see how it's useful in
> this case.
Using the usual 0 => no timeout, >0 => timeout in seconds would work,
but that would leave <0 for "use default timeout" which would be IMHO
not very intuitive. So that's why I did it like this. 

> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list