[rhel6-branch] Pass mountopts to swap options (#857517)

Brian C. Lane bcl at redhat.com
Tue Jul 9 16:25:42 UTC 2013


On Fri, Jun 28, 2013 at 07:01:11PM -0500, David Lehman wrote:
> On Fri, 2013-06-28 at 14:16 -0700, Brian C. Lane wrote:
> > From: "Brian C. Lane" <bcl at redhat.com>
> > 
> > swap is based on DeviceFormat, not FS, so mountopts weren't being
> > handled. It has its own options property though, so just pass on the
> > mountopts to options.
> 
> I think you could skip the 'if' wrapper since you're using kwargs.get.
> It will default to None if they key isn't in the dict. Or are you doing
> that because someone might have passed in options and you don't want to
> clobber that? Maybe it should be
> 
>   if not self.options:
> 
> instead of
> 
>   if "mountopts" in kwargs:

I want to leave options unset when mountopts hasn't been passed, trying
for the least amount of change.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130709/a3670390/attachment.sig>


More information about the anaconda-patches mailing list