[PATCH 6/7] Ignore double clicks on the DiskOverviews (#902467).

Chris Lumens clumens at redhat.com
Wed Jan 30 21:18:20 UTC 2013


The signal handler was getting called three times on double-click:  once
for the double-click, once for the first click, and once for the second
click.  This resulted in the background getting shown as if the disk were
selected, even though everything else indicated it was not.
---
 widgets/src/DiskOverview.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/widgets/src/DiskOverview.c b/widgets/src/DiskOverview.c
index 3aa2112..e3c39f4 100644
--- a/widgets/src/DiskOverview.c
+++ b/widgets/src/DiskOverview.c
@@ -250,7 +250,9 @@ gboolean anaconda_disk_overview_clicked(AnacondaDiskOverview *widget, GdkEvent *
     /* This handler runs for mouse presses and key releases.  For key releases, it only
      * runs for activate-type keys (enter, space, etc.).
      */
-    if (event->type == GDK_KEY_RELEASE &&
+    if (event->type != GDK_BUTTON_PRESS && event->type != GDK_KEY_RELEASE)
+        return FALSE;
+    else if (event->type == GDK_KEY_RELEASE &&
         (event->key.keyval != GDK_KEY_space && event->key.keyval != GDK_KEY_Return &&
          event->key.keyval != GDK_KEY_ISO_Enter && event->key.keyval != GDK_KEY_KP_Enter &&
          event->key.keyval != GDK_KEY_KP_Space))
-- 
1.7.11.2



More information about the anaconda-patches mailing list