[PATCH 1/4] Don't allow mountpoints to start with /proc or /sys either.

David Lehman dlehman at redhat.com
Tue Jan 22 21:41:31 UTC 2013


Have fun trying to please the pedants with the descriptions in patch 2,
but the whole set looks fine to me.

Dave

On Tue, 2013-01-22 at 16:31 -0500, Chris Lumens wrote:
> ---
>  pyanaconda/ui/gui/spokes/custom.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
> index 8f38eb4..6b3a4e4 100644
> --- a/pyanaconda/ui/gui/spokes/custom.py
> +++ b/pyanaconda/ui/gui/spokes/custom.py
> @@ -206,7 +206,8 @@ def validate_mountpoint(mountpoint, used_mountpoints, strict=True):
>          valid = MOUNTPOINT_IN_USE
>      elif not mountpoint:
>          valid = MOUNTPOINT_EMPTY
> -    elif mountpoint.startswith("/dev"):
> +    elif mountpoint.startswith("/dev") or mountpoint.startswith("/proc") or \
> +         mountpoint.startswith("/sys"):
>          valid = MOUNTPOINT_INVALID
>      elif (mountpoint.lower() not in fake_mountpoints and
>            ((len(mountpoint) > 1 and mountpoint.endswith("/")) or




More information about the anaconda-patches mailing list