[PATCH 4/4] Prepare structures to save spoke completenes for firstboot and GIE

Brian C. Lane bcl at redhat.com
Sat Jan 12 00:24:06 UTC 2013


On Fri, Jan 11, 2013 at 12:33:43PM +0100, Martin Sivak wrote:
> ---
>  pyanaconda/install.py   |  3 ++-
>  pyanaconda/kickstart.py | 28 ++++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/install.py b/pyanaconda/install.py
> index 1cccd9f..fa66019 100644
> --- a/pyanaconda/install.py
> +++ b/pyanaconda/install.py
> @@ -81,7 +81,8 @@ def doConfiguration(storage, payload, ksdata, instClass):
>  
>      with progress_report(_("Configuring addons")):
>          ksdata.addon.execute(storage, ksdata, instClass, u)
> -
> +        ksdata.configured_spokes.execute(storage, ksdata, instClass, u)
> +        

More of those pesky spaces!

> +        f = open(os.path.join(path, "configured.ini"), "a")
> +        for k,v in self.iteritems():
> +            f.write("%s=%s\n" % (k, v))
> +        f.close()

Why not use with open() as f: block here?

> +
> +        # Prepare the structure to track configured spokes
> +        self.configured_spokes = SpokeRegistry()
>          

Pre-existing spaces! Kill the spaces!

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130111/3e3afbb2/attachment-0001.sig>


More information about the anaconda-patches mailing list