[PATCH 1/4] Add the User creation spoke including the Advanced dialog

Brian C. Lane bcl at redhat.com
Thu Feb 28 18:13:46 UTC 2013


On Thu, Feb 28, 2013 at 11:09:39AM +0100, Martin Sivak wrote:

A few comments:
1 - should probably setup and use loggging
2 - I think it is :returns: not :return: isn't it?
3 - line 1018 or so, else: pass is unneeded
4 - looks like the gid code is partially disabled, on purpose?

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130228/03169a61/attachment-0001.sig>


More information about the anaconda-patches mailing list