[PATCH] Use GDBus also for connection settings update.

Radek Vykydal rvykydal at redhat.com
Thu Feb 28 11:24:42 UTC 2013

On 02/25/2013 09:37 PM, Brian C. Lane wrote:
> These loops are a bit hard to read, maybe add some whitespace? I'd also
> recommend changing the loop key values to key1 instead of key1_ and call
> the arguments new_key1 and new_key2 to make it more obvious what's
> happening.


> You may want to make a note in the docstring(s) that any value_type_str
> passed in will be overridden by existing type if found. And maybe rename
> it to default_type_str.

Done, sending new version.

More information about the anaconda-patches mailing list