[PATCH 2/2] Revert "Hook up the "Remove Packages" button on the dep solving error screen." (#905899).

Brian C. Lane bcl at redhat.com
Thu Feb 28 01:13:52 UTC 2013

On Wed, Feb 27, 2013 at 10:15:56AM -0500, Chris Lumens wrote:
> This reverts commit f4ec3d682ffd93dfc7105eaa09acdd7fd672a3e8.
> This patch also removes the button entirely.  All I've ever seen it do is reduce
> the installable package set to something like 30 packages and result in really
> cryptic bugs about commands that should be there failing to run.  It doesn't
> seem to help in just removing the one or two packages that have a problem,
> since it looks like it's frequently a core package with the problem.
> ---
>  pyanaconda/packaging/__init__.py     |  4 ----
>  pyanaconda/packaging/yumpayload.py   |  5 -----
>  pyanaconda/ui/gui/spokes/software.py | 31 ++++++++++++-------------------
>  3 files changed, 12 insertions(+), 28 deletions(-)

> +        from pyanaconda.threads import threadMgr

This looks fine except for all these imports. We already import
threadMgr at the top (and I'm no fan of imports inside methods)

Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130227/0d42ee5d/attachment.sig>

More information about the anaconda-patches mailing list