[PATCH] networking: new nm.py using GDBus, isys.py cleanup, network.py cleanup

Radek Vykydal rvykydal at redhat.com
Fri Feb 8 14:04:16 UTC 2013

Fear not, [06/17] - [17/17] could be squashed.

This patchset:

- Removes unused code from spokes/network.py. [01]
- Removes unused code from network.py. [03]
- Moves networking code from isys to network.py. [02,04]
- Adds new module nm.py for calling NetworkManager [05]
- Replaces code for communication with NM (dbus) from network.py
  with new module nm.py [06-17]

nm.py is using GDBus instead of dbus-python->libdbus which can have issues with
threads. Only _update_settings function is still using dbus-python, I need to
figure out how to construct updated GVariant settings object.  The nm.py
__main__ code is a starter for tests which I haven't written (yet) because of
lack of time.
Some other selling points:
- overall +/- ratio is + only because of better documentation of nm.py
- cleaner interface with return values and exceptions documented
- better modularity - no need to import network.py just to learn whether
  NM is connected

More information about the anaconda-patches mailing list