[blivet:rhel7/master 3/4] Change FS.label to a property (#1038590)

Anne Mulhern amulhern at redhat.com
Wed Dec 18 16:37:11 UTC 2013


> >  
> > +    def _setLabel(self, label):
> > +        if label is not None and (len(label) > 16 or len(label) == 0):
> > +            raise FSError("Filesystem label '%s' is incorrectly formatted
> > for %s." % (label, self.labelfsProg))
> > +        self._label = label
> > +
> 
> It's not valid to set the label to an empty string?
> 

I would prefer it not to be. It does not appear to be set to the empty string anywhere in blivet.

I believe that there is a spot in anaconda in custom.py where the label may be set to an empty string. But I'ld prefer to change that empty string to None before I call the constructor, rather than accept the empty string as an another way of saying None in the constructor.


More information about the anaconda-patches mailing list