[blivet:rhel7/master 0/4] Guard against bad filesystem labels
David Lehman
dlehman at redhat.com
Wed Dec 18 15:35:19 UTC 2013
On Tue, 2013-12-17 at 18:13 -0500, mulhern wrote:
> These changes are all brought about by rhbz#1038590
>
> The problem there is that the format of a filesystem label is unacceptable
> to the application that is used to set it.
>
> The idea is to catch the problem when the format is initialized instead
> of when the label is set.
>
> This will also require some changes to anaconda, to catch the exception
> thrown by the _setLabel method when calling, e.g., getFormat.
>
> I haven't done that yet, I'm seeking a review on the blivet side first.
Aside from my question about patch 3 these all look good.
David
>
> mulhern (4):
> Add some simple tests for file formats.
> Changes to _getLabelArgs and fields on which it depends (#1038590)
> Change FS.label to a property (#1038590)
> Remove label parameter from writeLabel method (#1038590)
>
> blivet/formats/fs.py | 101 +++++++++++++++++++++++++++++-----------
> tests/formats_test/__init__.py | 0
> tests/formats_test/misc_test.py | 97 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 172 insertions(+), 26 deletions(-)
> create mode 100644 tests/formats_test/__init__.py
> create mode 100755 tests/formats_test/misc_test.py
>
More information about the anaconda-patches
mailing list