[PATCH 2/2] Add shell spoke to s390x installations (#1019248)

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 17 08:04:11 UTC 2013


On Mon, 2013-12-16 at 10:22 -0800, Brian C. Lane wrote:
> On Mon, Dec 16, 2013 at 04:20:50PM +0100, Vratislav Podzimek wrote:
> > +    @classmethod
> > +    def should_run(cls, environment, data):
> > +        # run only in the installer on s390(x) machines
> > +        return environment == ANACONDA_ENVIRON and arch.isS390()
> 
> We should have some way to turn this spoke on w/o depending on s390 in
> order to make it easier to test. I hate suggesting another cmdline arg
> for it though. Maybe hook it up to flags.debug or flags.testing?
That's a good point. I think hooking it up to flags.debug should work
for us. Fixing locally and adding as a patch for the master branch.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list