[PATCH] Improve the workaround for Gtk's busted entry completion

Vratislav Podzimek vpodzime at redhat.com
Thu Dec 12 15:43:28 UTC 2013


On Thu, 2013-12-12 at 10:14 -0500, David Shea wrote:
> On 12/12/2013 05:07 AM, Vratislav Podzimek wrote:
> > On Wed, 2013-12-11 at 16:23 -0500, David Shea wrote:
> >> We can make GtkEntryCompletion work right just by calling the function
> >> that the property setter was supposed to call for itself instead of
> >> trying to keep track of focus events and keypresses and other gross
> >> things we shouldn't have to worry about.
> > The point of those signal handlers was to make ESC work for reverting to
> > the previous valid value of the entry and also to make entering value
> > and hitting TAB work. I'm afraid this change removes the functionality.
> >
> Argh, didn't even realize I'd broken that. Do you think we should we 
> should add the set_text_column bits to show the popup, or just wait for 
> newer Gtk to fix it for us?
I'd give them a chance. But if it's not fixed early in F21's scope, we
should probably do some magic on our side.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list