[blivet][PATCH] Make sure LUKS metadata fit in to the newly created device (#1038847)

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 10 16:45:22 UTC 2013


On Tue, 2013-12-10 at 10:40 -0600, David Lehman wrote:
> On Tue, 2013-12-10 at 17:22 +0100, Vratislav Podzimek wrote:
> > If there is a request to create encrypted device smaller than LUKS metadata
> > size, we should bump up the requested size with the metadata size to make sure
> > it fits in and negative values are not reported.
> 
> I think this should fix LUKS._minSize to reflect the metadata size and
> then use the minSize property so it can be a generic solution instead of
> only solving this problem for LUKS.
> 
> I'm also wondering if we should be raising an exception instead of
> quietly adjusting the size like this.
I'd like to fix this somehow for F20 ASAP. I'll try the _minSize
approach tomorrow, but I'm not sure I'll be able to come up with such
cleaner solution in one day without risk of breaking a lot of other
things.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list