[PATCH] Fix a couple warnings from -Werror=format-security (#1036989).

Chris Lumens clumens at redhat.com
Mon Dec 9 17:54:54 UTC 2013


> >diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c
> >index 48a8393..77977cf 100644
> >--- a/widgets/src/BaseWindow.c
> >+++ b/widgets/src/BaseWindow.c
> >@@ -18,6 +18,7 @@
> >   */
> >  #include <libintl.h>
> >+#include <locale.h>
> >  #include <stdlib.h>
> >  #include <string.h>
> Did you intend for the BaseWindow one to be in this patch? Either
> way, ack. We could add -Wformat-security to the CFLAGS in
> configure.ac and widgets/configure.ac, too.

Yeah - when I added CFLAGS=-Werror=format-security, it yelled at me that
it wouldn't do anything without -Wformat as well.  When I added that, I
got a build failure about that include being missing.

These flags are likely going to be added to the defaults in the builders
or in the rpm macros, I would guess.  So I think it will trickle down to
us eventually.

- Chris


More information about the anaconda-patches mailing list