[blivet 04/13] StorageDevice.minSize returns 0 if format's minSize is 0.

Martin Kolman mkolman at redhat.com
Mon Dec 9 13:34:42 UTC 2013


On Fri, 2013-12-06 at 11:06 -0600, David Lehman wrote:
> On Fri, 2013-12-06 at 11:50 -0500, mulhern wrote:
> > Previously, if format's minSize was 0, then it returned self.size instead.
> > I think this was an error, and the intention was to fall back on self.size
> > only if format.minSize was not set.
> 
> Many formats return 0 for minSize, meaning there is no known minimum
> size. It should be treated the same as None, since no formatting
> metadata can possibly exist without some space to store it in.
I'll just note that this is not the case for tmpfs - it lives in the
Kernel page cache and the metadata seem to live outside of the pages
allocated for the tmpfs mount (meaning that empty tmpfs is indeed
totally empty).
> 
> David
> 
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list