[PATCH] Use abstract base classes for mixins.

David Shea dshea at redhat.com
Thu Dec 5 19:18:48 UTC 2013


On 12/05/2013 09:46 AM, Chris Lumens wrote:
>>   po/POTFILES.in                      |   1 +
>>   pyanaconda/ui/gui/spokes/storage.py |  36 +------
>>   pyanaconda/ui/interfaces.py         | 184 ++++++++++++++++++++++++++++++++++++
>>   pyanaconda/ui/tui/spokes/source.py  |  95 ++-----------------
>>   4 files changed, 196 insertions(+), 120 deletions(-)
>>   create mode 100644 pyanaconda/ui/interfaces.py
> I definitely like the direction this is going.
>
> One thing I mentioned in IRC that I'll mention again here for posterity.
> I know I suggested "interfaces" as the name, but that could be confusing
> given that it's in the UI directory and doesn't really have much to do
> with a user interface.  Then again, perhaps we're smart enough to not
> get confused.
"helpers" from IRC is my favorite so far. Other contenders are 
"extensions", "bricks", "hammers", "wingdangdoodles". Not a lot of 
enthusiasm for anything. I mean I guess we could go with mixins if no 
one comes up with something better, but man, I hate that word.
>> +    @abstractproperty
>> +    def storage(self): pass
> Just a stylistic thing - I'd prefer the pass to be on its own line.
> That happens in a couple other places.
Changed locally.



More information about the anaconda-patches mailing list