[PATCH 1/2] Added tests for duplicated keyboard accelerators

Vratislav Podzimek vpodzime at redhat.com
Tue Aug 27 12:07:57 UTC 2013


On Tue, 2013-08-27 at 08:02 -0400, David Shea wrote:
> On 08/27/2013 05:06 AM, Vratislav Podzimek wrote:
> > On Mon, 2013-08-26 at 14:29 -0400, David Shea wrote:
> >> +# requires python-lxml
> >> +from lxml import etree
> > It would be better to put that import into a try-except block and
> > suggest user what should be done to make this test work. We do the same
> > in a couple of places.
> >
> Ok, I'll add that in. Should we keep a list somewhere of the packages 
> required to run tests that aren't in BuildRequires so that we can add 
> something like the install-buildrequires target? (install-checkrequires?)
That depends on if we ever want to run those checks as part of the build
process. I think that we should at least run unit tests that way.
Whether we will ever be able to run 'make check' that way I don't know.
But for know, I think that adding 'install-checkrequires' target would
be a good step. And it could just use some variable/macro in the
Makefile.am which we should be able to keep up to date.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list