[PATCH 0/2] makeupdates improvements

Vratislav Podzimek vpodzime at redhat.com
Thu Aug 15 20:25:10 UTC 2013


On Thu, 2013-08-15 at 14:49 +0200, Martin Kolman wrote:
> The first patch converts makeupdates to use argparse instead of getopt.
> This should provide more constant parsing for options that accept arguments
> and generally provides more robust features in less code.
> 
> The second patch adds a warning message when the Koji lookup thread can't find
> a package in Koji during the autofetch operation (when the -f/--fetch option is used).
> 
> As all package lookups are based on the content of the Anaconda specfile,
> then if such warning shows up in the makeupdates output, it will mostly probably
> indicate that a dependency was incorrectly specified in the Anaconda specfile.
> So this can be used as a very simple dependency checker. :)
> 
> Martin Kolman (2):
>   Convert makeupdates from getopt to argparse
>   Report if a package was not found in Koji during autofetch
> 
>  scripts/makeupdates | 135 ++++++++++++++++++++++------------------------------
>  1 file changed, 58 insertions(+), 77 deletions(-)
> 
These both look good to me, thanks for looking at it.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list