[pykickstart][PATCH 0/3] Check for incorrect autopart usage (rebase from RHEL6)

Martin Kolman mkolman at redhat.com
Tue Aug 13 15:51:30 UTC 2013


This is a rebased version of the recently pushed rhel6-branch patch,
that makes sure that the installation fails if autopart is used
together with par/partition, raid, logvol or volgroup in a single
kickstart file.
Ive added checking both to the RHEL6 command classes and to the
F20 ones - is that the correct way ?

There are also tests that check if the offending
command sequences correctly raise a parsing error.


Martin Kolman (3):
  Raise an error if autopart is combined with partitioning commands
    (#886010)
  Add class for idependent multi-line command sequence tests
  Add tests for incorrect command usage detection

 pykickstart/commands/autopart.py  | 66 +++++++++++++++++++++++++++++++++++++
 pykickstart/commands/logvol.py    | 16 +++++++++
 pykickstart/commands/partition.py | 21 ++++++++++++
 pykickstart/commands/raid.py      | 21 ++++++++++++
 pykickstart/commands/volgroup.py  | 26 +++++++++++++++
 pykickstart/handlers/control.py   | 10 +++---
 tests/baseclass.py                | 68 +++++++++++++++++++++++++++++++++++----
 tests/command_usage.py            | 54 +++++++++++++++++++++++++++++++
 8 files changed, 271 insertions(+), 11 deletions(-)
 create mode 100644 tests/command_usage.py

-- 
1.8.3.1



More information about the anaconda-patches mailing list