[master][PATCH 0/2] Fixes to user and group creation

David Shea dshea at redhat.com
Fri Aug 9 20:33:31 UTC 2013


The first patch touches a bunch of stuff in the user spoke: the username is
validated, and the thing in the advanced user configuration dialog where it
says it can create groups with a particular GID is fixed so that it a) works at
all, and b) doesn't keep old group creation ks directives around when you exit
and re-enter the dialog.

I'm not particularly happy with how I'm displaying the error message in the
advanced user dialog, so I'd like to hear opinions on that. I'm also not sure
how I should handle conflicts between ksdata group commands and the groups
added in the advanced user dialog (e.g., what to do if both specify the same
group name but different GIDs). Right now the way it's handled is to do nothing.

I did not move the user/group name validation into the TUI (it already has some
but it's more conservative). I also did not add a check for the "Full name"
field. Maybe it doesn't need one? I haven't checked.

The second patch just fixes a lying log message.


More information about the anaconda-patches mailing list