[PATCH] Fix the logging of the spice-vdagent status

Brian C. Lane bcl at redhat.com
Wed Aug 7 20:54:40 UTC 2013


On Wed, Aug 07, 2013 at 10:12:21AM -0400, David Shea wrote:
> ---
>  anaconda | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/anaconda b/anaconda
> index b17f7bd..596af1f 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -85,8 +85,10 @@ def startSpiceVDAgent():
>      status = os.system("spice-vdagent")
>  
>      # An error status usually means that we're not running on a virt guest
> -    if not status:
> -        log.info("spice-vdagent exited with status %d" % status)
> +    if os.WIFEXITED(status) and os.WEXITSTATUS(status)) == 0:

Looks like an extra )

But really, why not use iutil.execWithRedirect?

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130807/3cdaddb7/attachment.sig>


More information about the anaconda-patches mailing list