[PATCH 2/2] Added format.mountvisible flag.

Jan Safranek jsafrane at redhat.com
Tue Apr 23 15:23:14 UTC 2013


On 04/23/2013 04:46 PM, David Lehman wrote:
> On Tue, 2013-04-23 at 16:10 +0200, Jan Safranek wrote:
>> The flag tells, if the mount is visible or it is replaced by another mount.
>> Typically, on a F19 there is 'rootfs' mounted at '/' during boot, and later
>> the real device is mounted there too. /proc/mounts then shows:
> 
> The first patch is fine, but I think I would prefer a different approach
> for this one that does not involve adding a new attribute/flag. How
> about we instead go back and unset the mountpoint for any devices that
> already have the same mountpoint as the current device? It would look
> roughly like this:
> 
> old_mnt = self.mountpoints.get(mountpoint)
> if old_mnt:
>     old_mnt.format.mountpoint = None
>     old_mnt.format._mountpoint = None
> 
> Do you think that will work for you?

It's hiding of information. There are two filesystems mounted at one
place, not one. I'll check with architects.

Jan



More information about the anaconda-patches mailing list