[PATCH 0/3] Geolocation patches V2
Vratislav Podzimek
vpodzime at redhat.com
Thu Apr 18 09:31:12 UTC 2013
On Thu, 2013-04-11 at 15:39 +0200, Martin Kolman wrote:
> * the module now uses sphinx docstrings
> * can be configured by the "geoloc" boot option:
> not set - use geolocation with the default provider
> "0" - don't use geolocation
> "provider_mirror_manager" - use the Fedora MirrorManager
> for geolocation (default)
> "provider_hostip" - use Hostip.info
> * exceptions were converted to logged warnings
> * instead of setting the default language in the
> welcome spoke, I've left the default setting in
> kickstart.py and use the .seen flag to distinguish
> between the default and a value set by the user
> * won't run on image and directory installs
> * log messages are no longer translated
> * provider ids moved to constants
> * fix for anaconda not setting the seen flag for
> language set by boot option
> * code cleanup
>
>
> Martin Kolman (3):
> Add geolocation module
> Hook the Geolocation module to Anaconda
> Set seen for lang from option & use constant for default
>
> anaconda | 33 +-
> pyanaconda/constants.py | 15 +
> pyanaconda/geoloc.py | 779 ++++++++++++++++++++++++++++++++++++
> pyanaconda/ui/gui/spokes/welcome.py | 47 ++-
> 4 files changed, 862 insertions(+), 12 deletions(-)
> create mode 100644 pyanaconda/geoloc.py
>
Apart from the few comments this looks good to me. You can change
everything but the 'flags.cmdline' stuff locally before pushing. For the
'flags.cmdline' change please send a new version of the patch.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list