[PATCH 06/11] Populate the port combo on the filter spoke's search page.

Vratislav Podzimek vpodzime at redhat.com
Tue Apr 16 08:46:08 UTC 2013


On Tue, 2013-04-09 at 12:06 -0400, Chris Lumens wrote:
> ---
>  pyanaconda/ui/gui/spokes/filter.py | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/filter.py b/pyanaconda/ui/gui/spokes/filter.py
> index 5154349..7f3b527 100644
> --- a/pyanaconda/ui/gui/spokes/filter.py
> +++ b/pyanaconda/ui/gui/spokes/filter.py
> @@ -146,6 +146,13 @@ class SearchPage(FilterPage):
>          self._combo.set_active(0)
>          self._combo.emit("changed")
>  
> +        ports = []
> +        for disk in disks:
> +            if hasattr(disk, "node"):
> +                ports.append(str(disk.node.port))
You could use list comprehension here, but I'm not sure if it would be
equally readable or worse.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list