[PATCH 01/11] Add a button to bring up the Add Additional dialogs.

Chris Lumens clumens at redhat.com
Mon Apr 15 16:46:31 UTC 2013


> >I'll have to apply your patch and play with this to really see what you
> >mean.
> 
> screencast:
> http://rvykydal.fedorapeople.org/patch_iscsi_bind.webm

Ah, great.  Thanks.  Then, my one other comment would be that the
checkbox should be made insensitive once you press "Start Discovery".
We don't want people modifying the widgets while things are happening in
the background.

> One more thing I noticed - values of Target and LUN in Search tab seem
> to be wrong for iSCSI currently. Perhaps node.tpgt for the former can
> be used. For the latter, I don't know where is the best place to
> parse it from.

From just looking at what was available, I thought node.port would be
port and node.tpgt would be LUN, but I am honestly not all that familiar
with this stuff.  So other values very well could be more appropriate.

- Chris


More information about the anaconda-patches mailing list