[PATCH 01/11] Add a button to bring up the Add Additional dialogs.

Radek Vykydal rvykydal at redhat.com
Thu Apr 11 13:25:21 UTC 2013


I want to look at the patches and do proper review. For now I just tried
them and noticed that iscsi binding support is missing. Something we do in
RHEL 6 like this:

http://rvykydal.fedorapeople.org/rhel64iscsibind.webm

User can choose if he wants to bind targets to specific devices (internally
it affects what discovery returns). You can see ifaces in list
of nodes (for non-bound case there is "default"). After the first login
the choice (bind or not) can't be changed.

I am attaching a patch adding the support on top your patches. The checkbox
added to discovery tab should be probably UX-tuned. Also having the list
of discovered nodes with interfaces each row per each node/iface combination
is probably not the best:

Node        Iface
-------------------
target 1    p4p1
target 1    p4p2
target 2    p4p1
target 2    p4p2
target 3    p4p1

Perhaps the choice should be done in 2 stages - target and interface, eg:


Node        Iface
-------------------
target 1    ^p4p1    <- iface selection combobox in a cell
target 2    ^p4p2.
target 3    ^p4p1


or:

Node           ^p4p2  <- iface selection combobox filtering the list
-------------------
target1
target2


But it si something I'd do later.

I'd attach a screencast of the patch but our virt server is in bad
condition today.

Also one minor thing you are probably aware of:
Selecting Add iSCSI Target for 2nd time doesn't bring up the dialog unless
there has been change in combobox since the 1st time.

Radek

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-ford-iSCSI-iface-binding.patch
Type: text/x-patch
Size: 6399 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130411/423a0cbe/attachment.bin>


More information about the anaconda-patches mailing list