[PATCH] Fix two small problems with the UID/GID spin buttons (#929173, #929138).

Vratislav Podzimek vpodzime at redhat.com
Tue Apr 2 09:07:48 UTC 2013


On Mon, 2013-04-01 at 16:57 -0400, Chris Lumens wrote:
> (1) We should default to 1000 for both, since that's the first allowable
> user account (https://fedoraproject.org/wiki/Features/1000SystemAccounts).
> 
> (2) The values should be displayed by default.
> ---
>  pyanaconda/ui/gui/spokes/advanced_user.glade | 4 ++--
>  pyanaconda/ui/gui/spokes/user.py             | 3 +++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/advanced_user.glade b/pyanaconda/ui/gui/spokes/advanced_user.glade
> index 6159f53..b57700f 100644
> --- a/pyanaconda/ui/gui/spokes/advanced_user.glade
> +++ b/pyanaconda/ui/gui/spokes/advanced_user.glade
> @@ -421,14 +421,14 @@ Groups that do not already exist will be created; specify their GID in parenthes
>      </action-widgets>
>    </object>
>    <object class="GtkAdjustment" id="gid">
> -    <property name="lower">500</property>
> +    <property name="lower">1000</property>
>      <property name="upper">32535</property>
>      <property name="value">1000</property>
>      <property name="step_increment">1</property>
>      <property name="page_increment">10</property>
>    </object>
>    <object class="GtkAdjustment" id="uid">
> -    <property name="lower">500</property>
> +    <property name="lower">1000</property>
>      <property name="upper">32535</property>
>      <property name="value">1000</property>
>      <property name="step_increment">1</property>
> diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
> index 84bcb8f..3e22847 100644
> --- a/pyanaconda/ui/gui/spokes/user.py
> +++ b/pyanaconda/ui/gui/spokes/user.py
> @@ -80,6 +80,9 @@ class AdvancedUserDialog(GUIObject):
>          c_gid.set_active(bool(self._user.gid))
>          self._apply_checkboxes()
>  
> +        self.builder.get_object("spin_uid").update()
> +        self.builder.get_object("spin_gid").update()
> +
>          groups = []
>          for group_name in self._user.groups:
>              group = self._groupDict[group_name]
ACK.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list