[PATCH] Use gdk_threaded() when running AddLayout dialog

Chris Lumens clumens at redhat.com
Fri Sep 28 14:19:52 UTC 2012


> Without this whole GUI hangs in case this dialog is run to choose
> replacement for the last layout in the list of added layouts (minus
> button clicked).

There's likely to be more of this, too.

> @@ -264,8 +264,9 @@ class KeyboardSpoke(NormalSpoke):
>          dialog.refresh()
>          dialog.initialize()
>  
> -        with enlightbox(self.window, dialog.window):
> -            response = dialog.run()
> +        with gdk_threaded():
> +            with enlightbox(self.window, dialog.window):
> +                response = dialog.run()
>  
>          if response == 1:
>              duplicates = set()

python lets you do nested context managers like so:

    with gdk_threaded(), enlightbox(...):

It saves the indentation but now that I've typed it out I'm not sure
it's very clear.  So, whatever.

- Chris


More information about the anaconda-patches mailing list